There are a couple of issues which need to be corrected which show up when validating the OPAC search results page: - A typo in opac-results.tt, an extra quote: <option value="newlist">[ New list ]</option>" - <span id="login4tags"> is repeated, creating duplicate ids. This can be changed to a class.
Created attachment 116331 [details] [review] Bug 27628: Fix minor HTML markup errors in OPAC search results templates This patch makes a couple of minor corrections to templates related to OPAC search results: An errant quote, and invalidly repeating ids. The #login4tags id is changed to a class, and CSS related to this id (which was not used) is removed. For consistency, the id is changed to a class on the detail page as well. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a search in the OPAC. Confirm that the "Log in to add tags" link still looks correct at various browser widths. - Confirm that it works to trigger the login modal. - Validate the source of the page. There should be no errors. - View the detail page for a bibliographic record. - The "Log in to add tags" link should look correct and work correctly.
Created attachment 116333 [details] [review] Bug 27628: Fix minor HTML markup errors in OPAC search results templates This patch makes a couple of minor corrections to templates related to OPAC search results: An errant quote, and invalidly repeating ids. The #login4tags id is changed to a class, and CSS related to this id (which was not used) is removed. For consistency, the id is changed to a class on the detail page as well. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a search in the OPAC. Confirm that the "Log in to add tags" link still looks correct at various browser widths. - Confirm that it works to trigger the login modal. - Validate the source of the page. There should be no errors. - View the detail page for a bibliographic record. - The "Log in to add tags" link should look correct and work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 116445 [details] [review] Bug 27628: Fix minor HTML markup errors in OPAC search results templates This patch makes a couple of minor corrections to templates related to OPAC search results: An errant quote, and invalidly repeating ids. The #login4tags id is changed to a class, and CSS related to this id (which was not used) is removed. For consistency, the id is changed to a class on the detail page as well. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform a search in the OPAC. Confirm that the "Log in to add tags" link still looks correct at various browser widths. - Confirm that it works to trigger the login modal. - Validate the source of the page. There should be no errors. - View the detail page for a bibliographic record. - The "Log in to add tags" link should look correct and work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Doesn't apply cleanly to 20.05. Please rebase if needed.