Created attachment 116431 [details] Duplicate Warning See attachment. Why is the message "This item is on hold for another patron." duplicated?
Created attachment 116581 [details] [review] Bug 27645: Prevent "is on hold" warning to be displayed twice During a batch checkout we display the "item is on hold" message depending on different conditions. However it can happen the message is displayed twice. If the checkout is not impossible then we see: This item is on hold for another patron. This item is on hold for another patron. The hold will be overridden, but not cancelled. We should only display the second one. Test plan: With a default ktd setup you can simply place an item on hold and use the batch checkout tool to check it out
Created attachment 116586 [details] [review] Bug 27645: Prevent "is on hold" warning to be displayed twice During a batch checkout we display the "item is on hold" message depending on different conditions. However it can happen the message is displayed twice. If the checkout is not impossible then we see: This item is on hold for another patron. This item is on hold for another patron. The hold will be overridden, but not cancelled. We should only display the second one. Test plan: With a default ktd setup you can simply place an item on hold and use the batch checkout tool to check it out Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 116793 [details] [review] Bug 27645: Prevent "is on hold" warning to be displayed twice During a batch checkout we display the "item is on hold" message depending on different conditions. However it can happen the message is displayed twice. If the checkout is not impossible then we see: This item is on hold for another patron. This item is on hold for another patron. The hold will be overridden, but not cancelled. We should only display the second one. Test plan: With a default ktd setup you can simply place an item on hold and use the batch checkout tool to check it out Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.