Created attachment 116500 [details] [review] Bug 27654: Sort module.keys hash when render columns_settings.tt On the "Administration -> Table settings" page, the order of "tables related to pages" sections is different with each page refresh. Cause of that is that Perl gives random order for hash keys where those elements are stored on template render. To avoid that we add a "sort" method where getting keys similarly how it was done previously to display tables always in the same order. To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open any collapsed module settings, for example "Acquisition tables". Check the order of pages. 3) Reload the page. Check the order of the same elements again. They always come in random order, it's easily distinguishable. 4) Apply the patch. 5) Repeat steps 1-3 again and ensure that the order of pages stays the same no matter how many times you reload the page.
Created attachment 116532 [details] [review] Bug 27654: Sort module.keys hash when render columns_settings.tt On the "Administration -> Table settings" page, the order of "tables related to pages" sections is different with each page refresh. Cause of that is that Perl gives random order for hash keys where those elements are stored on template render. To avoid that we add a "sort" method where getting keys similarly how it was done previously to display tables always in the same order. To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open any collapsed module settings, for example "Acquisition tables". Check the order of pages. 3) Reload the page. Check the order of the same elements again. They always come in random order, it's easily distinguishable. 4) Apply the patch. 5) Repeat steps 1-3 again and ensure that the order of pages stays the same no matter how many times you reload the page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 116574 [details] [review] Bug 27654: Sort module.keys hash when render columns_settings.tt On the "Administration -> Table settings" page, the order of "tables related to pages" sections is different with each page refresh. Cause of that is that Perl gives random order for hash keys where those elements are stored on template render. To avoid that we add a "sort" method where getting keys similarly how it was done previously to display tables always in the same order. To reproduce: 1) Head over to /cgi-bin/koha/admin/columns_settings.pl 2) Open any collapsed module settings, for example "Acquisition tables". Check the order of pages. 3) Reload the page. Check the order of the same elements again. They always come in random order, it's easily distinguishable. 4) Apply the patch. 5) Repeat steps 1-3 again and ensure that the order of pages stays the same no matter how many times you reload the page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.03
Pushed to 20.05.x for 20.05.09
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.