SetImportBatchStatus is not called with $batch_id It has been caught by bug 25026, and www/search_utf8.t fails with t/db_dependent/www/search_utf8.t .. 14/87 Error POSTing http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl: Internal Server Error at t/db_dependent/www/search_utf8.t line 240. And, from logs: manage-marc-import.pl: C4::ImportBatch::SetImportBatchStatus(): DBI Exception: DBD::mysql::st execute failed: Truncated incorrect DOUBLE value: 'importing' [for Statement "UPDATE import_batches SET import_status = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1='importing'] at /kohadevbox/koh a/C4/ImportBatch.pm line 579: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=2
Created attachment 116641 [details] [review] Bug 27669: Fix 'importing' and 'reverting' statuses when importing/reverting a batch SetImportBatchStatus is not called with $batch_id It has been caught by bug 25026, and www/search_utf8.t fails with t/db_dependent/www/search_utf8.t .. 14/87 Error POSTing http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl: Internal Server Error at t/db_dependent/www/search_utf8.t line 240. And, from logs: manage-marc-import.pl: C4::ImportBatch::SetImportBatchStatus(): DBI Exception: DBD::mysql::st execute failed: Truncated incorrect DOUBLE value: 'importing' [for Statement "UPDATE import_batches SET import_status = ? WHERE import_batch_id = ?" with ParamValues: 0=undef, 1='importing'] at /kohadevbox/koh a/C4/ImportBatch.pm line 579: /kohadevbox/koha/tools/manage-marc-import.pl, referer: http://koha:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=2 Test plan: Read the changes and confirm it does make sense. Import and revert a batch
It will also fix t/db_dependent/www/batch.t that is currently failing on My8 with the same error.
With bug 25026, this one is blocker.
Pushing it.
Patch pushed to master for 21.05.00
Pushed to 20.11.x for 20.11.03
With this patch on 20.05, my batch import never completes. It just sits at 0% progress. I haven't found anything in the error logs. Not backporting.