Bug 2776 - emailPurchaseSuggestions system preference deprecated
Summary: emailPurchaseSuggestions system preference deprecated
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: PC All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-11 07:26 UTC by Chris Cormack
Modified: 2019-05-01 13:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:55:44 UTC


---- Reported by rch@liblime.com 2008-11-11 19:26:31 ----

The system preference exists in 3.0, yet is not implemented in the code.
I'll submit a patch to remove the system preference.



---- Additional Comments From nengard@gmail.com 2008-12-19 10:38:00 ----

Why remove it?  I have people who aren't using Acq, that still want to receive suggestions and so they like the email option.



---- Additional Comments From joe.atzberger@liblime.com 2009-04-07 20:03:00 ----

(In reply to comment #1)
> Why remove it?  I have people who aren't using Acq, that still want to receive
> suggestions and so they like the email option.
> 

Because it IS NOT IMPLEMENTED.  That is to say, it does nothing and certainly won't do anything but confuse people who expect all Koha's switches to connect to something.  



---- Additional Comments From nengard@gmail.com 2009-04-18 16:46:19 ----

This says a patch was sent - did that patch make this preference work?



---- Additional Comments From gmcharlt@gmail.com 2009-04-25 02:14:30 ----

Patch pushed.



---- Additional Comments From gmcharlt@gmail.com 2009-04-25 02:15:35 ----

(In reply to comment #3)
> This says a patch was sent - did that patch make this preference work?
> 

No, the patch simply removes the syspref.  There is no sign that it *ever* worked.  If any wants to dig up or create code to make it possible to email purchase suggestions, it can be added back later.



---- Additional Comments From nengard@gmail.com 2009-04-27 14:05:03 ----

I like the way the purchase suggestions are handled in Acq - but not all libraries use Acq, so maybe we need to add a way to mark an item as 'ordered' without actually ordering it via the acq module - that way will make it so that we don't really need this preference anyway.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:55 UTC  ---

This bug was previously known as _bug_ 2776 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2776

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was rch@liblime.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was rch@liblime.com.
CC member joe.atzberger@liblime.com does not have an account here