Finnish libraries that we're supporting are actively using holds-to-pull feature, according to their reports, having ability to filter the table by "Pickup place" will help them be more efficient, as they often process those holds in batches by pickup places. They already tested that in the modified older version of Koha, and with plugin as well, which proved that they definitely need this feature and it helps libraries a lot. External reference for this request from Finnish libraries: https://tiketti.koha-suomi.fi/issues/4537
Created attachment 117305 [details] [review] Bug 27790: separate earliest hold date into two different columns Currently "Earliest hold date" and "Pickup place" are displayed in one single column, but to make filtering possible it is necessary to split those fields into separate ones. This patch does exactly that and adds sorting list drop down feature to the "Pickup place" column. To reproduce: 1) Make a few holds and head over to "Circulations->Holds to pull". 2) Ensure that pickup place and earliest hold date are in the same column "Earliest hold date" 3) Apply the patch. 4) Check "Circulations->Holds to pull list" again, this time booking date and pickup place should have their own columns. Ensure that filtering by "pickup location" works fine.
Created attachment 117332 [details] [review] Bug 27790: separate earliest hold date into two different columns Currently "Earliest hold date" and "Pickup place" are displayed in one single column, but to make filtering possible it is necessary to split those fields into separate ones. This patch does exactly that and adds sorting list drop down feature to the "Pickup place" column. To reproduce: 1) Make a few holds and head over to "Circulations->Holds to pull". 2) Ensure that pickup place and earliest hold date are in the same column "Earliest hold date" 3) Apply the patch. 4) Check "Circulations->Holds to pull list" again, this time booking date and pickup place should have their own columns. Ensure that filtering by "pickup location" works fine. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120123 [details] [review] Bug 27790: separate earliest hold date into two different columns Currently "Earliest hold date" and "Pickup place" are displayed in one single column, but to make filtering possible it is necessary to split those fields into separate ones. This patch does exactly that and adds sorting list drop down feature to the "Pickup place" column. To reproduce: 1) Make a few holds and head over to "Circulations->Holds to pull". 2) Ensure that pickup place and earliest hold date are in the same column "Earliest hold date" 3) Apply the patch. 4) Check "Circulations->Holds to pull list" again, this time booking date and pickup place should have their own columns. Ensure that filtering by "pickup location" works fine. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120124 [details] [review] Bug 27790: (QA follow-up) Fix offsets due to new columns
Created attachment 120229 [details] [review] Bug 27790: Add the new column to columns_settings.yml
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x