We can leverage some jEditable configuration options to improve the behavior of the inline-editable fields in the Point of Sale interface: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry Unfortunately jEditable doesn't seem to have an option to add an "inputmode" attribute.
Created attachment 117306 [details] [review] Bug 27792: Improve jEditable configuration for point of sale fields This patch alters the configuration of the "cost" and "quantity" editable fields in the "This sale" table on the Point of Sale page: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry To test you must have EnablePointOfSale and UseCashRegisters enabled and configured. - Apply the patch and go to the Point of Sale page. - Add some items for purchase. - In the "This sale" table, click the values in the "cost" and "quantity" columns and try editing their values. - The form field which appears should not fill the width of the table column. - The fields should enforce the correct input: Currency for the "cost" column, digits for the "quantity" column. - The fields should update when you click out of them and the correct values should appear in the "Collect payment" area.
Created attachment 117324 [details] [review] Bug 27792: Improve jEditable configuration for point of sale fields This patch alters the configuration of the "cost" and "quantity" editable fields in the "This sale" table on the Point of Sale page: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry To test you must have EnablePointOfSale and UseCashRegisters enabled and configured. - Apply the patch and go to the Point of Sale page. - Add some items for purchase. - In the "This sale" table, click the values in the "cost" and "quantity" columns and try editing their values. - The form field which appears should not fill the width of the table column. - The fields should enforce the correct input: Currency for the "cost" column, digits for the "quantity" column. - The fields should update when you click out of them and the correct values should appear in the "Collect payment" area. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 117325 [details] [review] Bug 27792: (follow-up) Double escape the escape The JSON patturn wasn't getting interpreted correctly for me.. the `\` characters needed escaping with a second `\`. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 117412 [details] [review] Bug 27792: Improve jEditable configuration for point of sale fields This patch alters the configuration of the "cost" and "quantity" editable fields in the "This sale" table on the Point of Sale page: - Reduce field with to reduce jumpy table re-draws. - Replace "numeric" input type with "text" - Add pattern attribute for enforcing currency/number entry To test you must have EnablePointOfSale and UseCashRegisters enabled and configured. - Apply the patch and go to the Point of Sale page. - Add some items for purchase. - In the "This sale" table, click the values in the "cost" and "quantity" columns and try editing their values. - The form field which appears should not fill the width of the table column. - The fields should enforce the correct input: Currency for the "cost" column, digits for the "quantity" column. - The fields should update when you click out of them and the correct values should appear in the "Collect payment" area. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 117413 [details] [review] Bug 27792: (follow-up) Double escape the escape The JSON patturn wasn't getting interpreted correctly for me.. the `\` characters needed escaping with a second `\`. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.04
Enhancement, not backporting to 20.05