A number of vendors send data in the FTX segment of EDI quotes, and expect this to be returned in the subsequent order. This may indicate the form of item to be supplied (electronic v physical book) or data entered to indicate that the order is the result of a special request. The standard is somewhat misleading on this as it encourages use of FTX for encoded delivery priority info. However this appears to be obsolete in practice and examination of numerous quotes show no suppliers using it this way, whereas some suppliers (e.g. proquest) are making the contents of this segment fundamental to their procedures ensure FTX content is saved (in vendornote) and that the saved note is included in an order sent as a result of the quote
Created attachment 117307 [details] [review] Patch to save Quote FTX segment and to include it outgoing order
Created attachment 117556 [details] [review] Bug 27793: Store FTX free text in vendor note This is important for proquest ordering to distinguish types of material. FTX segment from quote is stored as vendor note. Contents of vendornote are included in the order FTX segment.
Created attachment 118743 [details] [review] Bug 27793: Store FTX free text in vendor note This is important for proquest ordering to distinguish types of material. FTX segment from quote is stored as vendor note. Contents of vendornote are included in the order FTX segment. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Moving directly to PQA.
Unit tests are missing. I don't think we should continue to add new enhancements to EDI without test coverage.
I've struggled to write a test here.. I think it would be great to integrate this for this cycle, and I'll try to work through tests for EDI as a more thorough job as a roadmap task during the next cycle.. does that sound reasonable Jonathan?
Please rebase on top of bug 26989. The conflict seems trivial but I don't want to mess with this code (or even touch it).
Created attachment 120483 [details] [review] Bug 27793: Store FTX free text in vendor note This is important for proquest ordering to distinguish types of material. FTX segment from quote is stored as vendor note. Contents of vendornote are included in the order FTX segment. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Last time I am pushing an EDI enhancement without test coverage.
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x
*** Bug 18637 has been marked as a duplicate of this bug. ***
Surprise backport! Backported: Pushed to 20.11.x branch for 20.11.15 It's for bug 29670 comment 20
Do I need to backport this to 19.11.x? I probably won't unless there is a need for it
It depends indirectly on bug 27708 so no need for 19.11.x
Not backported to 19.11.x