Created attachment 117396 [details] Screenshot of POS "This sale" in fr-CA The "Remove" button in "This sale" in the point of sale is untranslatable. To reproduce: 1- Enable EnablePointOfSale syspref 2- Enable UseCashRegisters syspref 3- Set up at least one cash register in Administration > Cash registers 4- Set up at least on Debit type that can be sold through POS in Administration > Debit types 5- Install at least one other language in your staff interface and switch to that language 6- Go to Point of sale and click Add next to one item for purchase 7- Notice on the right hand side where the purchased item is added, the Removed button is still in English I checked po/fr-CA-staff-prog.po, po/fr-CA-messages.po and po/fr-CA-messages-js.po and none of them have a "Remove" string in pay.tt.
Created attachment 117444 [details] [review] Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation: > perl translate install fr-FR - In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button.
Created attachment 117553 [details] [review] Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation: > perl translate install fr-FR - In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 117734 [details] [review] Bug 27815: "Remove" in point of sale untranslatable This patch modifies the Point of Sale template so that the "Remove" button can be translated. The string in the JavaScript block wasn't wrapped in the correct function. To test, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template: e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from pos/pay.tt for translation to confirm the update, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:189 #, c-format msgid "Remove" msgstr "Enlever" - Install the updated translation: > perl translate install fr-FR - In the staff client, go to Point of Sale. - Switch to the French translation and click the "Ajouter" button next to one of the items for purchase. - In the "This sale" table, the item you added should have a corresponding "Enlever" button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.04
Pushed to 20.05.x for 20.05.10
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.