Created attachment 117989 [details] view of this With a new feature, from bug 23019, coming in 20.11, the ability to create a profile in Stage Marc Records for Import. Unfortunately, the box that a librarian needs to fill out is greyed out- this could be very confusing to the process- as greyed out usually means, these field/s are not usable. Could this Profile Name box be not greyed out? In addition, it might be helpful to have a text box (tip box) that could tell the user what to do when wanting to create a new profile.
Created attachment 127817 [details] [review] Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: <profile_name>" - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link.
I Failed QA on this one because the "Save profile" button does not become enabled (it is still greyed out) immediately upon typing something in the field. It only becomes enabled upon a click, tab or enter which is confusing.
Created attachment 127958 [details] [review] Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: <profile_name>" - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link.
Created attachment 127962 [details] [review] Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: <profile_name>" - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
This worked perfectly. I really like this new layout - it is so much more intuitive.
Created attachment 130025 [details] [review] Bug 27904: Improve display in creating profile for staging MARC records for import This patch updates the Stage MARC records for import page, in particular the format of the part of the form for saving or removing a profile. The page moves these controls into their own fieldset so that it is clear they are separate from the "Stage for import" button. The "Remove" control now includes the name of the profile which will be removed. To test, apply the patch and go to Tools -> Stage MARC for import. - Upload a file of records. - Make some changes to the settings and options. - At the bottom of the form you should see a "Save profile" fieldset. - Confirm that the "Save profile" button becomes enabled if you type something in the field (or paste something, or select something from form history). - Confirm that the profile is saved correctly by re-uploading a MARC file and selecting your newly added/edited profile and confirming that the values are set as expected. - In the "Save profile" section there should be a "Remove" link styled with a Bootstrap "trash" icon: "Remove profile: <profile_name>" - Confirm that profile deletion still works correctly. - Confirm that the "Remove" link is updated correctly when you make a selection from the "Profile" dropdown at the top of the form: - Choosing "Do not use profile" should change the "Remove" link to drop the name of the profile and disable the link. - Choosing different profiles should update the name in the "Remove" link. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Barbara Johnson from comment #5) > This worked perfectly. I really like this new layout - it is so much more > intuitive. +1 :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]