To test: - Confirm that you have the 952$o linked to the cn_browser.pl plugin in the default framework - send one or more items to batch mod - confirm that the call number field does not give you a regex option - inspect the call number field in your browser, confirm the regex controls are there but not displayed (<span name="regex_fields" style="display: none;">) - go back to your default framework, unlink the 952$o from the plugin - reload your batch mod, confirm regex shows
Created attachment 118148 [details] [review] Bug 27929: Allow regex for subfield linked with cataloguing plugin
Should we allow it for all subfields linked with a cataloguing plugin or cn_browser is an exception? This patch is not perfect as the "..." of the plugin must be hidden when regex is checked.
I think it would make sense to show the regex option independent of the cataloguing plugin. Examples I can think of: - dateaccessioned: I could make sense to change them in batch, it's only a date. - barcode: It could make sense. to change a branch prefix maybe? Not sure, but would not hurt. - stocknumber: often also linked to a plugin, batch edit could also make sense for old data here.
See test plan from comment 0.
Created attachment 121660 [details] [review] Bug 27929: Allow regex for subfield linked with cataloguing plugin Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 121870 [details] [review] Bug 27929: Allow regex for subfield linked with cataloguing plugin Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 121871 [details] [review] Bug 27929: (QA follow-up) Hide tag editor on regex Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
Pushed to 20.11.x for 20.11.08
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.