This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/modules/circ/checkout-notes.tt intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt intranet-tmpl/prog/en/modules/circ/overdue.tt intranet-tmpl/prog/en/modules/circ/pendingreserves.tt intranet-tmpl/prog/en/modules/circ/transfers_to_send.tt intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
Created attachment 118427 [details] [review] Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue
Created attachment 118437 [details] [review] Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue
Created attachment 118456 [details] [review] Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great bit of cleaning up, thanks Owen. Signing off
Created attachment 118798 [details] [review] Bug 27974: (follow-up) Address missing instance - Circulation -> Article requests - Both the "Pending" and "Processing" tabs.
Created attachment 118895 [details] [review] Bug 27974: Replace obsolete title-string sorting: Circulation templates This patch modifies several circulation templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Circulation -> Checkout notes - To populate the table, enable the "AllowCheckoutNotes" system preference enabled, log in to the OPAC as a user with checkouts. From the "Your summary" page use the "Report a problem" fields to submit notes. - Circulation -> On-site checkouts - Requires the "OnSiteCheckouts" system preference to be enabled and and for some items to be checked out as on-site checkouts. - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Transfers to send - Requires the "StockRotation" preference to be enabled, some rotas to be set up, and for the stockrotation cron job to be executed. - Circulation -> Transfers to receive - Circulation -> Holds queue Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 118896 [details] [review] Bug 27974: (follow-up) Address missing instance - Circulation -> Article requests - Both the "Pending" and "Processing" tabs. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I wonder if we should change the module to Templates as that would make them all sort together in release notes and as we expect no behaviour change.
Good idea to change the module :)
Is that correct to remove "html" for on-site_checkouts.tt?
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x