This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt intranet-tmpl/prog/en/modules/acqui/booksellers.tt intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt intranet-tmpl/prog/en/modules/acqui/histsearch.tt intranet-tmpl/prog/en/modules/acqui/invoice-files.tt intranet-tmpl/prog/en/modules/acqui/invoice.tt intranet-tmpl/prog/en/modules/acqui/invoices.tt
Created attachment 118468 [details] [review] Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files
Created attachment 118491 [details] [review] Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files
Created attachment 118580 [details] [review] Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great work, Passing QA
Created attachment 118783 [details] [review] Bug 27982: (follow-up) Address missing instances - Acquisitions -> Invoices - With AcqEnableFiles enabled, attach some files to an invoice: - Invoice details
Created attachment 118786 [details] [review] Bug 27982: (follow-up) Address another missing instance Remove "title-string" option from invoice-files dataTable initialization.
Created attachment 118787 [details] [review] Bug 27982: (follow-up) Address another missing instance Remove "title-string" option from staged file dataTable initialization.
Created attachment 118845 [details] [review] Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 118846 [details] [review] Bug 27982: (follow-up) Address missing instances - Acquisitions -> Invoices - With AcqEnableFiles enabled, attach some files to an invoice: - Invoice details Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 118847 [details] [review] Bug 27982: (follow-up) Address another missing instance Remove "title-string" option from staged file dataTable initialization. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Applied 27982 and 27983 together. Grepped for title-string in the acqui dir and in js includes. No further cases found.. well caught on the extra's Owen. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x