This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc intranet-tmpl/prog/en/modules/serials/claims.tt intranet-tmpl/prog/en/modules/serials/serials-collection.tt intranet-tmpl/prog/en/modules/serials/serials-search.tt intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
Created attachment 118551 [details] [review] Bug 27998: Replace obsolete title-string sorting: Serials templates This patch modifies several serials templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - With the Mana service configured in system preferences, go to Serials -> New subscription and add a subscription for a bibliographic record which will match titles in Mana. In the Mana search results, the "Last import" column should sort correctly. - Serials -> Claims - Serials -> Search - Serials -> Subscription details - The affected table is "Acquisition details," so your subscription must have orders associated with it (I eyeballed this change, so could use extra help testing this area). - Serials -> Subscription details -> Serial collection
Created attachment 118670 [details] [review] Bug 27998: Replace obsolete title-string sorting: Serials templates To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - With the Mana service configured in system preferences, go to Serials -> New subscription and add a subscription for a bibliographic record which will match titles in Mana. In the Mana search results, the "Last import" column should sort correctly. - Serials -> Claims - Serials -> Search - Serials -> Subscription details - The affected table is "Acquisition details," so your subscription must have orders associated with it (I eyeballed this change, so could use extra help testing this area). - Serials -> Subscription details -> Serial collection
Created attachment 118790 [details] [review] Bug 27998: (follow-up) Address missing instanced Remove title-string option from dataTable configurations.
Created attachment 118900 [details] [review] Bug 27998: Replace obsolete title-string sorting: Serials templates This patch modifies several serials templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - With the Mana service configured in system preferences, go to Serials -> New subscription and add a subscription for a bibliographic record which will match titles in Mana. In the Mana search results, the "Last import" column should sort correctly. - Serials -> Claims - Serials -> Search - Serials -> Subscription details - The affected table is "Acquisition details," so your subscription must have orders associated with it (I eyeballed this change, so could use extra help testing this area). - Serials -> Subscription details -> Serial collection Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 118901 [details] [review] Bug 27998: (follow-up) Address missing instances Remove title-string option from dataTable configurations. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x