This issue affects library who have nultiple budgets. If a library rolls over their budget and has duplicated funds when viewing old invoices they adjust will appear as if they are using the current funds To recreate 1 - In acquisitions go to a vendor 2 - Click 'Receive' 3 - Create an invoice 4 - Finish receiving 5 - Go to Admin->budgets 6 - Duplicate your current budget 7 - Mark the original budget inactive 8 - View the invoice you created 9 - No indication the budget is inactive Note that adding new adjustments does show only the active budget unless you request to see inactive.
Created attachment 118549 [details] [review] Bug 28003: Invoice adjustments using inactive budgets do not indicate that status This patch affects the display of existing invoice adjustments to indicate when using an inactive budget To recreate 1 - In acquisitions go to a vendor 2 - Click 'Receive' 3 - Create an invoice 4 - Finish receiving 5 - Go to Admin->budgets 6 - Duplicate your current budget 7 - Mark the original budget inactive 8 - View the invoice you created 9 - No indication the budget is inactive 10 - Apply patch 11 - Reload the page 12 - The fund shows '(inactive)' 13 - The dropdown to edit the funds also indicates which funds are inactive Note that adding new adjustments does show only the active budget unless you request to see inactive.
Created attachment 118711 [details] [review] Bug 28003: Invoice adjustments using inactive budgets do not indicate that status To test 1 - In acquisitions go to a vendor 2 - Click 'Receive' 3 - Create an invoice 4 - Finish receiving 5 - Go to Admin->budgets 6 - Duplicate your current budget 7 - Mark the original budget inactive 8 - View the invoice you created 9 - No indication the budget is inactive 10 - Apply patch 11 - Reload the page 12 - The fund shows '(inactive)' 13 - The dropdown to edit the funds also indicates which funds are inactive
Created attachment 118817 [details] [review] Bug 28003: Invoice adjustments using inactive budgets do not indicate that status This patch affects the display of existing invoice adjustments to indicate when using an inactive budget To recreate 1 - In acquisitions go to a vendor 2 - Click 'Receive' 3 - Create an invoice 4 - Finish receiving 5 - Go to Admin->budgets 6 - Duplicate your current budget 7 - Mark the original budget inactive 8 - View the invoice you created 9 - No indication the budget is inactive 10 - Apply patch 11 - Reload the page 12 - The fund shows '(inactive)' 13 - The dropdown to edit the funds also indicates which funds are inactive Note that adding new adjustments does show only the active budget unless you request to see inactive. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix, nice improvement.. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Pushed to 20.05.x for 20.05.11
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.