The breadcrumbs menu on the serial claims page can be expanded to provide additional context when a vendor has been selected.
Created attachment 118835 [details] [review] Bug 28036: Improve breadcrumbs of serial claims page This patch modifies the serial claims script and templates so that better context can be shown in the page title and page breadcrumbs when a vendor has been selected. To test, apply the patch and go to Serials -> Claims. - The initial state of the page title and breadcrumbs should show "Serials > Claims." - Select a vendor. The page title and breadcrumbs show show "Serials > Claims > Claims for <vendor name>."
Bug 28036: Improve breadcrumbs of serial claims page This patch modifies the serial claims script and templates so that better context can be shown in the page title and page breadcrumbs when a vendor has been selected. To test, apply the patch and go to Serials -> Claims. - The initial state of the page title and breadcrumbs should show "Serials > Claims." - Select a vendor. The page title and breadcrumbs show show "Serials > Claims > Claims for <vendor name>." -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 28036: Improve breadcrumbs of serial claims page fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28036: Improve breadcrumbs of serial claims page The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". ------------------ Patch not applied.
Depends on Bug 27846.
Created attachment 118871 [details] [review] Bug 28036: Improve breadcrumbs of serial claims page This patch modifies the serial claims script and templates so that better context can be shown in the page title and page breadcrumbs when a vendor has been selected. To test, apply the patch and go to Serials -> Claims. - The initial state of the page title and breadcrumbs should show "Serials > Claims." - Select a vendor. The page title and breadcrumbs show show "Serials > Claims > Claims for <vendor name>." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This works well, just wondering a tiny bit about the variable names. I think we should probably be using vendor, not supplier? Also seem to remember that we had standardized on booksellerid in the acq module at some point as a compromise.
Created attachment 118913 [details] [review] Bug 28036: Improve breadcrumbs of serial claims page This patch modifies the serial claims script and templates so that better context can be shown in the page title and page breadcrumbs when a vendor has been selected. To test, apply the patch and go to Serials -> Claims. - The initial state of the page title and breadcrumbs should show "Serials > Claims." - Select a vendor. The page title and breadcrumbs show show "Serials > Claims > Claims for <vendor name>." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x