Bug 1277 added options to the Z39.50 search form but didn't take into account that search terms for those new fields might be passed in the URL. For example, a URL containing all possible fields: /cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear ...should bring up a form which has values in every field. Instead, these fields are empty: Subject heading Keyword (any) LC call number Control no. Dewey Standard ID
Created attachment 119309 [details] [review] Bug 28112: Z39.50 does not populate form with all passed criteria This patch adds output of some already-existing template variables in the Z39.50 search form so that all parameters can be used to prepopulate the form. To test, apply the patch and go to Cataloging. - Click the "New from Z39.50/SRU" button - A window should pop up and the form should be empty. - Confirm that searching works correctly. - Perform the same test from a bibliographic detail page using the Edit menu -> Replace record via Z39.50/SRU. - Some fields in the search form should be prepopulated, e.g. ISBN, title, author. - Paste this link into your browser: http://path.to.your.koha/cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear - The search form should appear with all fields prepopulated. - Perform the same tests in Acquisitions with the option for adding to a basket via an external search. - The link for testing all parameters: http://path.to.your.koha/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=4&basketno=3&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear
Created attachment 119316 [details] [review] Bug 28112: Z39.50 does not populate form with all passed criteria This patch adds output of some already-existing template variables in the Z39.50 search form so that all parameters can be used to prepopulate the form. To test, apply the patch and go to Cataloging. - Click the "New from Z39.50/SRU" button - A window should pop up and the form should be empty. - Confirm that searching works correctly. - Perform the same test from a bibliographic detail page using the Edit menu -> Replace record via Z39.50/SRU. - Some fields in the search form should be prepopulated, e.g. ISBN, title, author. - Paste this link into your browser: http://path.to.your.koha/cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear - The search form should appear with all fields prepopulated. - Perform the same tests in Acquisitions with the option for adding to a basket via an external search. - The link for testing all parameters: http://path.to.your.koha/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=4&basketno=3&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear Signed-off-by: David Nind <david@davidnind.com>
The "try another search" button will put you back on the prefilled form if you are using acqui/z3950_search. However cataloguing/z3950_search will display a blank form. Can be considered outside of the scope here.
Created attachment 119567 [details] [review] Bug 28112: Z39.50 does not populate form with all passed criteria This patch adds output of some already-existing template variables in the Z39.50 search form so that all parameters can be used to prepopulate the form. To test, apply the patch and go to Cataloging. - Click the "New from Z39.50/SRU" button - A window should pop up and the form should be empty. - Confirm that searching works correctly. - Perform the same test from a bibliographic detail page using the Edit menu -> Replace record via Z39.50/SRU. - Some fields in the search form should be prepopulated, e.g. ISBN, title, author. - Paste this link into your browser: http://path.to.your.koha/cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear - The search form should appear with all fields prepopulated. - Perform the same tests in Acquisitions with the option for adding to a basket via an external search. - The link for testing all parameters: http://path.to.your.koha/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=4&basketno=3&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Pushed to 20.05.x for 20.05.11
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.