Some librarians would fine it useful to include the transaction timestamp when viewing the two register detail tables (sales and past_sales). The tables are a bit in different than others in Koha, transaction occupy two table rows and the description spans 2 columns. This leaves some table cells unused. Rather than adding a new column to these tables I purpose adding the transaction timestamp into the unused <td> in the Transaction column.
Created attachment 119435 [details] [review] Bug 28127: add transaction timestampt to register details tables To Test: -Enable POS and setup some registers -Make some transactions -Go to Point of Sale > Register details and look at the two tables, sales and past sales -No timestamp or transaction date -Apply patch and look again -See Tranactions dates in the Transaction column
Created attachment 119447 [details] [review] Bug 28127: add transaction timestampt to register details tables To Test: -Enable POS and setup some registers -Make some transactions -Go to Point of Sale > Register details and look at the two tables, sales and past sales -No timestamp or transaction date -Apply patch and look again -See Tranactions dates in the Transaction column Signed-off-by: David Nind <david@davidnind.com>
Created attachment 119809 [details] [review] Bug 28127: Add transaction timestamp to register details tables To Test: -Enable POS and setup some registers -Make some transactions -Go to Point of Sale > Register details and look at the two tables, sales and past sales -No timestamp or transaction date -Apply patch and look again -See Tranactions dates in the Transaction column Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
(In reply to Katrin Fischer from comment #3) > Created attachment 119809 [details] [review] [review] > Bug 28127: Add transaction timestamp to register details tables > > To Test: > -Enable POS and setup some registers > -Make some transactions > -Go to Point of Sale > Register details and look at the two tables, sales > and past sales > -No timestamp or transaction date > -Apply patch and look again > -See Tranactions dates in the Transaction column > > Signed-off-by: David Nind <david@davidnind.com> > > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Ah now there are 2 patches, older with "add" and newer with "Add". But the older has been pushed to master : https://git.koha-community.org/Koha-community/Koha/commit/572c0981c3f678fbb32476b8060ca79f0e642016 How fix this ?
I'd love to see this backported to 20.05 if possible. Thanks!
Created attachment 122166 [details] [review] Bug 28127: [20.05.x] Add transaction timestamp to register details tables
Personally.. I think if this is backported then bug 28390 should be too in quick succession as it fixes a bug with this implimentation.
Comment on attachment 119809 [details] [review] Bug 28127: Add transaction timestamp to register details tables Patch with "add" was pushed to master so I obsolete patch with "Add". It will be missing "Signed-off-by: Katrin Fischer" but we know it ;)
OK so we wait on Bug 28390