As it makes for unnecessary long translations and is not consistent with our labelling on other pages, I suggest to make the following changes to the buttons on the acq basket summary: * Delete this basket => Delete basket * Close this basket => Close basket Note: Close basket will only show, when the basket is not marked as standing order and at least one order line has been added.
Created attachment 119453 [details] [review] Bug 28132: Remove "this" from button descriptions on basket summary page This patch modifies button text on the Acquisitions basket page to remove the word "this." To test, apply the patch, go to Acquisitions, and locate a vendor with baskets. - View an open basket. - You should see in the button toolbar, "Delete basket," and "Close basket." - View a closed basket. - You should see a "Reopen basket" button.
Created attachment 119468 [details] [review] Bug 28132: Remove "this" from button descriptions on basket summary page This patch modifies button text on the Acquisitions basket page to remove the word "this." To test, apply the patch, go to Acquisitions, and locate a vendor with baskets. - View an open basket. - You should see in the button toolbar, "Delete basket," and "Close basket." - View a closed basket. - You should see a "Reopen basket" button. Signed-off-by: David Nind <david@davidnind.com>
Willing to fix the basketgroup view at the same time? koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt: <div class="btn-group"><a href="[% script_name | url %]?op=reopen&basketgroupid=[% basketgroupid | uri %]&booksellerid=[% booksellerid | uri %]&mode=singlebg" class="btn btn-default" id="reopenbutton"><i class="fa fa-download"></i> Reopen this basket group</a></div> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt: <div class="btn-group"><a href="[% script_name | url %]?op=export&basketgroupid=[% basketgroupid | uri %]&booksellerid=[% booksellerid | uri %]" class="btn btn-default" id="exportbutton"><i class="fa fa-download"></i> Export this basket group as CSV</a></div> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt: <div class="btn-group"><a href="[% script_name | url %]?op=print&basketgroupid=[% basketgroupid | uri %]&booksellerid=[% booksellerid | uri %]" class="btn btn-default" id="printbutton"><i class="fa fa-download"></i> Print this basket group in PDF</a></div> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <li><a href="/cgi-bin/koha/acqui/basket.pl?op=close&basketno=[% basket.basketno | uri %]&booksellerid=[% basket.booksellerid | uri %]"><i class="fa fa-times-circle"></i> Close this basket</a></li>
Created attachment 119557 [details] [review] Bug 28132: (follow-up) Update basket group page This patch makes the same change to the basket group page: Reopen this basket -> Reopen basket Export this basket -> Export basket Print this basket -> Print basket
Created attachment 119562 [details] [review] Bug 28132: Remove "this" from button descriptions on basket summary page This patch modifies button text on the Acquisitions basket page to remove the word "this." To test, apply the patch, go to Acquisitions, and locate a vendor with baskets. - View an open basket. - You should see in the button toolbar, "Delete basket," and "Close basket." - View a closed basket. - You should see a "Reopen basket" button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 119563 [details] [review] Bug 28132: (follow-up) Update basket group page This patch makes the same change to the basket group page: Reopen this basket -> Reopen basket Export this basket -> Export basket Print this basket -> Print basket Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks, Owen!
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Enhancement, not backported to 20.05