When writing off a single debit that contains an itemnumber, we should pass that itemnumber to the writeoff so it can be properly connected to the item in the accountlines description. It looks like we did so in 19.11 and stopped in 20.05.
Created attachment 119578 [details] [review] Bug 28147: Pass itemnumber through to Account->pay Currently the itemnumber is not passed through when paying a single fine, we should do that To test: 1 - Create a manual debit and provide a barcode so the debit is linked to an item 2 - Go to the 'Make a payment' tab. Click the 'Writeoff' button on the individual line 3 - View the 'Transactions tab' The writeoff has no item details 4 - Apply patch 5 - Repeat 1 & 2 6 - View the transactions tab. The writeoff shows item details 7 - Confirm 'Writeoff amount' and 'Writeoff selected' still work and do not link to item
Created attachment 119627 [details] [review] Bug 28147: Pass itemnumber through to Account->pay Currently the itemnumber is not passed through when paying a single fine, we should do that To test: 1 - Create a manual debit and provide a barcode so the debit is linked to an item 2 - Go to the 'Make a payment' tab. Click the 'Writeoff' button on the individual line 3 - View the 'Transactions tab' The writeoff has no item details 4 - Apply patch 5 - Repeat 1 & 2 6 - View the transactions tab. The writeoff shows item details 7 - Confirm 'Writeoff amount' and 'Writeoff selected' still work and do not link to item Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix, works as expected.. Signing off
Going straight for QA on this one.. it's super clear and fixes a regression. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Pushed to 20.05.x for 20.05.11
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.