For name authorities, when you do a z39.50 search the value of 100$a (or 110$a) is prefilled in the search form, but from a topic/subject authority, the value of 150$a is not prefilled. That's because topic/subject: authorities.tt puts it into the search URL as "&topic=goats" (because GetMandatoryFieldZ3950 in authorities/authorities.pl told it to), but cataloguing/z3950_auth_search.pl expects to find it in &subject=goats.
Well, that and the way the template doesn't actually put the subject value into the input, once there is a subject value.
Created attachment 119781 [details] [review] Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record For names and uniform titles, when you do a z39.50 search from an authority record, we prefill what's in the relevant tag's subfield a in the search form, but for subjects, we don't, both because GetMandatoryFieldZ3950 thinks the param is topic when it's actually subject, and because z3950_auth_search.tt doesn't bother putting the value of &subject into the form. Test plan: 1) Authorities - New authority - Topical Term 2) Tab 1, click on HEADING-TOPICAL TERM to expand subfields 3) In subfield a, type goats 4) Click Z39.50/SRU search and verify that the Subject heading search field has goats prefilled
Created attachment 119948 [details] [review] Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record For names and uniform titles, when you do a z39.50 search from an authority record, we prefill what's in the relevant tag's subfield a in the search form, but for subjects, we don't, both because GetMandatoryFieldZ3950 thinks the param is topic when it's actually subject, and because z3950_auth_search.tt doesn't bother putting the value of &subject into the form. Test plan: 1) Authorities - New authority - Topical Term 2) Tab 1, click on HEADING-TOPICAL TERM to expand subfields 3) In subfield a, type goats 4) Click Z39.50/SRU search and verify that the Subject heading search field has goats prefilled Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120714 [details] [review] Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record For names and uniform titles, when you do a z39.50 search from an authority record, we prefill what's in the relevant tag's subfield a in the search form, but for subjects, we don't, both because GetMandatoryFieldZ3950 thinks the param is topic when it's actually subject, and because z3950_auth_search.tt doesn't bother putting the value of &subject into the form. Test plan: 1) Authorities - New authority - Topical Term 2) Tab 1, click on HEADING-TOPICAL TERM to expand subfields 3) In subfield a, type goats 4) Click Z39.50/SRU search and verify that the Subject heading search field has goats prefilled Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06