Bug 28206 - Waiting holds should be filled at checkout even if they violate holds policies
Summary: Waiting holds should be filled at checkout even if they violate holds policies
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-23 14:52 UTC by Andrew Fuerste-Henry
Modified: 2023-05-25 18:27 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28206: Move tests to a subtest (4.14 KB, patch)
2021-04-30 09:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 28206: Add tests (2.17 KB, patch)
2021-04-30 09:46 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2021-04-23 14:52:14 UTC
To recreate:
- have or create a valid hold
- check the item in, capture the hold
- confirm the hold shows as waiting for the patron
- set AllowHoldsOnDamagedItems to Don't Allow
- mark the item as damamged
- try to place another hold on this same bib for another patron of the same category, confirm that hold is no longer valid because the item is no longer considered valid
- check the item out to your original patron
- confirm the hold still shows as Waiting and no feedback is given as to why

I'd like Koha to simply mark that hold as filled -- if the library is doing the checkout, they likely want the hold filled. Alternatively, we should at least give an alert that mentions the hold and asks whether it should be filled, cancelled, or reverted.
Comment 1 Jonathan Druart 2021-04-30 09:30:16 UTC
Andrew, does it mean bug 10452 was incorrect?
Comment 2 Jonathan Druart 2021-04-30 09:46:36 UTC
Created attachment 120331 [details] [review]
Bug 28206: Move tests to a subtest
Comment 3 Jonathan Druart 2021-04-30 09:46:40 UTC
Created attachment 120332 [details] [review]
Bug 28206: Add tests