The math that we do on this page uses data elements parent_id and self_id to ensure we add only the parent budgets and don't add any more than once. When a budget is negative, however, we don't add these elements and this then totals child funds an additional time To recreate: 1 - Have a parent fund and a child fund 2 - Order an amount from the child fund that is greater than the amount available 3 - Browse to acquisitions 4 - Confirm the totals look right 5 - Click on the over spent fund to go to 'Funds for main budget' 6 - Note the totals are incorrect
Created attachment 120172 [details] [review] Bug 28223 - Add data elements to negative budgets To test: 1 - Have a parent fund and a child fund 2 - Order an amount from the child fund that is greater than the amount available 3 - Browse to acquisitions 4 - Confirm the totals look right 5 - Click on the over spent fund to go to 'Funds for main budget' 6 - Note the totals are incorrect 7 - Apply patch 8 - Reload 9 - Totals are now correct
Created attachment 120173 [details] [review] Bug 28223 - Add data elements to negative budgets To test: 1 - Have a parent fund and a child fund 2 - Order an amount from the child fund that is greater than the amount available 3 - Browse to acquisitions 4 - Confirm the totals look right 5 - Click on the over spent fund to go to 'Funds for main budget' 6 - Note the totals are incorrect 7 - Apply patch 8 - Reload 9 - Totals are now correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected.. can't believe I missed this during QA first time around! Passing QA
Created attachment 120207 [details] [review] Bug 28223: Add data elements to negative budgets To test: 1 - Have a parent fund and a child fund 2 - Order an amount from the child fund that is greater than the amount available 3 - Browse to acquisitions 4 - Confirm the totals look right 5 - Click on the over spent fund to go to 'Funds for main budget' 6 - Note the totals are incorrect 7 - Apply patch 8 - Reload 9 - Totals are now correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
Pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.