Many libraries use discover tools as front-end to their resources. These tools are not dealing very well with item specific data such as itemcallnumber. In any case, that's what we observe with Summon, Ex-libris tool wich is not able to map different items with different itemcallnumbers. That problem can have a solution through GetAvailability method. After checking availability and getting the location of the document, patrons often don't go further in their search. When they arrived on the site they are missing only one data : the itemcallnumber. That would be perfect to add it to the method and so give all minimal but sufficient data to find the document on the place. Olivier Crouzet
Created attachment 120242 [details] [review] Add itemcallnumber to ilsdi GetAvailability output
Test plan : To see the output of getavailability service, run the following url in your browser : [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio or this one [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item where the [OPACBASEURL] is the opac url of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] a record number and itemnumber of your choice. After applying the patch, you'll see an extra tag itemcallnumber. Exemple : <dlf:itemcallnumber>840.08 COR R</dlf:itemcallnumber>
Created attachment 121399 [details] [review] Bug 28238 Add itemcallnumber to ils-di GetAvailability output Signed-off-by: David Nind <david@davidnind.com>
Testing notes (koha-testing-docker): - Enabled ILS-DI - Locate a record with multiple items to test with - Made sure the items had call numbers - Followed test plan Note - the QA team may want the commit message formatted according to the commit message guidelines: https://wiki.koha-community.org/wiki/Commit_messages Here is my attempt: Bug 28328: Add itemcallnumber to ILS-DI GetAvailability output Providing the call number for ILS-DI GetAvailability output is useful for libraries that use discovery tools. Patrons often don't check further for the call number, and then they don't have it when they look for the item. Test plan: 1. Enable the ILS-DI system preference 2. Locate a record with multiple items and make sure they have call numbers for each item 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Run the queries from step 3 again - the results should now have an extra tag itemcallnumber. Example: <dlf:itemcallnumber>840.08 COR R</dlf:itemcallnumber> 6. Sign off!
Comment on attachment 120242 [details] [review] Add itemcallnumber to ilsdi GetAvailability output For some reason I created an additional patch when signing off!
If we are going to add it, I think we should return it even if item is unavailable - perhaps the patron wants to make a request for it, or to check the surrounding shelves if their item is not available. Consistency is nice when we can attain it.
Created attachment 126909 [details] [review] Bug 28328: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for unavailable items Providing the call number for ILS-DI GetAvailability output is useful for libraries that use discovery tools. Patrons often don't check further for the call number, and then they don't have it when they look for the item. It could also be use full to have this call number when the item isn't available (to make a request for it for instance). Test plan: 1. Enable the ILS-DI system preference 2. Locate a record with multiple items and make sure they have call numbers for each item and that some are unavailable 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Run the queries from step 3 again - all the results should now have the tag itemcallnumber (not only the available's ones) Example: <dlf:itemcallnumber>840.08 COR R</dlf:itemcallnumber> Sponsored-by: University Lyon 3
Created attachment 126947 [details] [review] Bug 28238 Add itemcallnumber to ils-di GetAvailability output Signed-off-by: David Nind <david@davidnind.com>
Created attachment 126948 [details] [review] Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for unavailable items Providing the call number for ILS-DI GetAvailability output is useful for libraries that use discovery tools. Patrons often don't check further for the call number, and then they don't have it when they look for the item. It could also be use full to have this call number when the item isn't available (to make a request for it for instance). Test plan: 1. Enable the ILS-DI system preference 2. Locate a record with multiple items and make sure they have call numbers for each item and that some are unavailable 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Run the queries from step 3 again - all the results should now have the tag itemcallnumber (not only the available's ones) Example: <dlf:itemcallnumber>840.08 COR R</dlf:itemcallnumber> Sponsored-by: University Lyon 3 https://bugs.koha-community.org/show_bug.cgi?id=28238 Signed-off-by: David Nind <david@davidnind.com>
I amended the commit message for the follow up so that it has the correct bug number.
(In reply to David Nind from comment #10) > I amended the commit message for the follow up so that it has the correct > bug number. Thank you David for the correction. I obsoleted the patch with the wrong bug number.
Created attachment 127130 [details] [review] Bug 29374: Don't crash if search engine returns a deleted record Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 127131 [details] [review] Bug 28238: Add itemcallnumber to ils-di GetAvailability output Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 127132 [details] [review] Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for unavailable items Providing the call number for ILS-DI GetAvailability output is useful for libraries that use discovery tools. Patrons often don't check further for the call number, and then they don't have it when they look for the item. It could also be use full to have this call number when the item isn't available (to make a request for it for instance). Test plan: 1. Enable the ILS-DI system preference 2. Locate a record with multiple items and make sure they have call numbers for each item and that some are unavailable 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Run the queries from step 3 again - all the results should now have the tag itemcallnumber (not only the available's ones) Example: <dlf:itemcallnumber>840.08 COR R</dlf:itemcallnumber> Sponsored-by: University Lyon 3 https://bugs.koha-community.org/show_bug.cgi?id=28238 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Overall this patch is quite clean, examples and documentation have been updated and existing patches still pass: prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. ok All tests successful. Files=1, Tests=10, 12 wallclock secs ( 0.02 usr 0.03 sys + 8.42 cusr 1.12 csys = 9.59 CPU) Result: PASS I am inclined to pass this change as is, but we are missing a specific test for the new feature. Maybe someone would be willing to step up here?
(In reply to Katrin Fischer from comment #15) > I am inclined to pass this change as is, but we are missing a specific test > for the new feature. Maybe someone would be willing to step up here? Yes, I am sorry, no more exceptions.
Created attachment 127478 [details] [review] Bug 28238: (follow-up) Add tests Add specific tests for the tag itemcallnumber in GetAvailability output. Sponsored-by: University Lyon 3
Created attachment 129489 [details] [review] Bug 28238: Add tests Add specific tests for the tag itemcallnumber in GetAvailability output. Sponsored-by: University Lyon 3 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 129490 [details] [review] Bug 28238: Add itemcallnumber to ils-di GetAvailability output Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 129491 [details] [review] Bug 28238: (follow-up) Add itemcallnumber to ILS-DI GetAvailability output for unavailable items Providing the call number for ILS-DI GetAvailability output is useful for libraries that use discovery tools. Patrons often don't check further for the call number, and then they don't have it when they look for the item. It could also be use full to have this call number when the item isn't available (to make a request for it for instance). Test plan: 1. Enable the ILS-DI system preference 2. Locate a record with multiple items and make sure they have call numbers for each item and that some are unavailable 3. Test these URLs: [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[BIBLIONUMBER]&id_type=biblio and [OPACBASEURL]/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=[ITEMNUMBER]&id_type=item (Where the [OPACBASEURL] is the OPAC URL of your test instance, [BIBLIONUMBER] and [ITEMNUMBER] are a record number and item number of your choice.) 4. Apply the patch 5. Run the queries from step 3 again - all the results should now have the tag itemcallnumber (not only the available's ones) Example: <dlf:itemcallnumber>840.08 COR R</dlf:itemcallnumber> Sponsored-by: University Lyon 3 https://bugs.koha-community.org/show_bug.cgi?id=28238 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
I've added the sponsor to release-tools. There was already "Université Jean Moulin Lyon 3", but prefer english version. So always patch with line : Sponsored-by: University Lyon 3
(In reply to Fridolin Somers from comment #22) > I've added the sponsor to release-tools. > There was already "Université Jean Moulin Lyon 3", but prefer english > version. > So always patch with line : > > Sponsored-by: University Lyon 3 Did you ask them? They are in the mailmap as "Université de Lyon 3".
I've mailled them directly
I think in general the institution should pick what they what want to be listed as. Not everyone has an official English name to use.
Pushed to 21.11.x for 21.11.03
Enhancement, not backported to 21.05.