I don't know if it's an oversight or because they couldn't be NULL anymore if $Price is used but in /cgi-bin/koha/admin/itemtypes.pl page detail defaultreplacecost and processfee aren't formatted unlike To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals.
Created attachment 120427 [details] [review] Bug 28280: itemtype page, add price formatting To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals.
Created attachment 121502 [details] [review] Bug 28280: itemtype page, add price formatting To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals. Signed-off-by: David Nind <david@davidnind.com>
Testing notes (koha-testing-docker): - Numbers are displayed with six decimals when you edit the item type, otherwise they display correctly on the item type listing page
Created attachment 121573 [details] [review] Bug 28280: itemtype page, add price formatting To Test: 1- create an item type with a 'Default replacement cost' and a 'Processing fee (when lost)' 2- numbers are displayed with 6 decimals. 4- apply patch 5- numbers are displayed with 2 decimals. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
Pushed to 20.11.x for 20.11.08
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.