Caused by commit e37bfe3e4b395ef71a54c65226829248847cf1ce Bug 20443: Remove extended_attributes_code_value_arrayref AND C4::Members::Attributes sort { $a->{code} cmp $b->{code} || $a->{value} cmp $b->{value} } map { my @arr = split /:/, $_, 2; { code => $arr[0], attribute => $arr[1] } First line must be sort { $a->{code} cmp $b->{code} || $a->{attribute} cmp $b->{attribute} }
It generates warnings Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/Koha/Patrons/Import.pm line 550, <$fh> line 2. And does not sort correctly (no fallback on the attribute's value for repeatable attributes)
Created attachment 120606 [details] [review] Bug 28293: (bug 20443 follow-up) Fix wrong key in Patrons::Import->generate_patron_attributes It generates warnings Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/Koha/Patrons/Import.pm line 550, <$fh> line 2. And does not sort correctly (no fallback on the attribute's value for repeatable attributes)
Tests on bug 28220 cover this (at least get rid of the warnings) Test plan: Apply patches from bug 28220. Without this patch you see warnings.
Created attachment 120823 [details] [review] Bug 28293: (bug 20443 follow-up) Fix wrong key in Patrons::Import->generate_patron_attributes It generates warnings Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/Koha/Patrons/Import.pm line 550, <$fh> line 2. And does not sort correctly (no fallback on the attribute's value for repeatable attributes) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Clear fix, works as expected and squashes warnings.. Going straight for QA..
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
Pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.