We duplicate the code for the 'Search the catalog' box in many different include files, we should use a single file that is included where needed
Created attachment 120977 [details] [review] Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers
Created attachment 120978 [details] [review] Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers
Created attachment 122345 [details] [review] Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam <hakam@inlibro.com>
Created attachment 122346 [details] [review] Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam <hakam@inlibro.com>
(In reply to Hakam Almotlak from comment #4) > Created attachment 122346 [details] [review] [review] > Bug 28356: Consolidate catalogue search box code > > To test: > 1 - Apply patch > 2 - Confirm searchign the catalog works from: > Administration->Budgets > Cataloging > Circulation->Check in > Administration->Cities and towns > Acquisitions->{Vendor}->Contracts > Administration->Currencies > Administration->Circulation desks (requires UseCirculationDesks > preference) > Home > Tools->Notices and slips > Patrons > Adminstration > Serials > Acquisitions->Suggestions > Administration->Z39.50/SRU servers > > Signed-off-by: hakam <hakam@inlibro.com> You forgot to change status to "Signed off" no ?
Moving to Signed-Off, QA queue
Created attachment 124814 [details] [review] Bug 28356: Consolidate catalogue search box code To test: 1 - Apply patch 2 - Confirm searchign the catalog works from: Administration->Budgets Cataloging Circulation->Check in Administration->Cities and towns Acquisitions->{Vendor}->Contracts Administration->Currencies Administration->Circulation desks (requires UseCirculationDesks preference) Home Tools->Notices and slips Patrons Adminstration Serials Acquisitions->Suggestions Administration->Z39.50/SRU servers Signed-off-by: hakam <hakam@inlibro.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Passing QA. Note: Administration->Cities and towns search was already broken before this patch.
Nice one!
Pushed to master for 21.11, thanks to everybody involved!