There are some issues with alignment, padding, and other styles that I'd like to correct on admin/categories.tt
Created attachment 121191 [details] [review] Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in <div class="hint"> like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Administration -> Patron categories -> New category and confirm that the style updates look good.
Created attachment 121202 [details] [review] Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in <div class="hint"> like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Very nice improvements! Looks good on all screen sizes (all screen sizes that I test at least)
Created attachment 123135 [details] [review] Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in <div class="hint"> like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported for 21.05