In reports, the link to the database schema points to the main page and the user must select their version. We know what version they're using, so we should append the version number to the link so that it takes them directly there.
Created attachment 121429 [details] [review] Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previous version, e.g. 'origin/20.11.x' you will see a link directly to that schema page.
Created attachment 121491 [details] [review] Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previous version, e.g. 'origin/20.11.x' you will see a link directly to that schema page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
tested in origin/20.05.x and origin/20.11.x works well in both and this is a handy enhancement!
Hi Owen, could you please fix the link on the start page of the reports module as well?
Created attachment 123801 [details] [review] Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previously released version, e.g. 'tags/v20.11.08' you will see a link directly to that schema page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 123802 [details] [review] Bug 28454: (follow-up) Add schema version to link on reports home page This patch makes the same changes to the script and template for the reports home page.
Created attachment 123917 [details] [review] Bug 28454: Add Koha version number to database schema link in reports This patch modifies the guided reports script, adding a verion check so that a version string can be added to the database schema link if the user is using a non-development version. To test, apply the patch and go to reports -> Saved reports. - In the left-hand sidebar menu you should see a "Koha database schema" link. Depending on which version you're using, it may or may not have a version string included, e.g. "http://schema.koha-community.org/20_05" - In master, there is no version string added because there is no schema available for development versions. - If you apply the patch on a previously released version, e.g. 'tags/v20.11.08' you will see a link directly to that schema page. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 123918 [details] [review] Bug 28454: (follow-up) Add schema version to link on reports home page This patch makes the same changes to the script and template for the reports home page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
The second patch is removing lines that is not related to this change (and not advertised in the commit message). Is that expected? Moreover you are duplicating code (that exists already), why don't you use 'Koha.Version' from the template instead?
Created attachment 124084 [details] [review] Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link in reports
Owen, this is what I had in mind.
Created attachment 125073 [details] [review] Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link in reports Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 125074 [details] [review] Bug 28454: (follow-up) Add missing filters
Created attachment 125316 [details] [review] Bug 28454: [ALTERNATIVE PATCH] Add Koha version number to database schema link in reports Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 125317 [details] [review] Bug 28454: (follow-up) Add missing filters Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches will be squashed when pushed.
Pushed to master for 21.11, thanks to everybody involved!
*** Bug 25525 has been marked as a duplicate of this bug. ***