Bug 28273 broke the form. To reproduce: 1. Have a club with some enrollments 2. Search for some biblio and try adding a club hold => FAIL: things are not ok with the dropdown.
Created attachment 121532 [details] [review] Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options
Created attachment 121553 [details] [review] Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121566 [details] [review] Bug 28496: Club holds pickup locations don't come from the API This patch fixes a issue that is generated by the fact different inputs were reusing the same id. To test: 1. Have a club with some enrollments 2. Make sure you have your circ rules to allow any library be a pickup location. 3. Search for a biblio 4. Try placing a club hold => FAIL: The dropdown only has the (currently) logged in library. 5. Apply this patch 6. Repeat 3-4 => SUCCESS: The dropdown has all the options Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.01
Depends on Bug 28273 not in 20.11.x