There is not much benefit to using "no" instead of "number", and it makes it less translateable and understandable. This should be fixed in three places that I can see: 1. the search filter form 2. the results table column heading 3. when there are no results, there is text that says 'Search was:' and a label that says 'Invoice no.'
Created attachment 121736 [details] [review] Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form.
Created attachment 121796 [details] [review] Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. Signed-off-by: Salman Ali <salman@outaouais>
Created attachment 121921 [details] [review] Bug 28508: Use "Invoice number" instead of "Invoice no" on the invoice search filter This patch corrects instances of the abbreviated phrase "Invoice no." from the templates, making it "Invoice number." Also corrected: An instance of "Bookseller" is replaced with "Vendor." To test, apply the patch and confirm that the phrase is correct in these cases: - Acquisitions -> Invoices: Check the "Search filters" form in the left-hand sidebar. -> View an invoice: Check the label in the form. - Acquisitions -> Vendor -> Receive shipments: Check the table of invoices. - Acquisitions -> Orders search (in the search header) -> Advanced search: Check the labels in the form. Signed-off-by: Salman Ali <salman.ali@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Note: I fixed Salman's SO line
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported to 21.05.x