The road type pull down in the OPAC doesn't use the OPAC description. If one is set, it should be used with a fall back to the normal description.
Created attachment 121692 [details] [review] Bug 28511: Road types in OPAC should prefer OPAC description if one exists This patch modifies the patron entry form in the OPAC so that if street types are defined in authorized values, the OPAC description is preferred. To test, apply the patch and go to Administration -> Authorized values. - Add or edit entries in the "ROADTYPE" category. - Some entries should have only the "Description" set, while others should have "Description" and "Description (OPAC)". - In the OPAC, open the patron registration page. Check the "Stree type" drop down in the "Main address" section. - For entries which have an OPAC description, this value should show. - For entries without an OPAC description the default should show.
Created attachment 121696 [details] [review] Bug 28511: Road types in OPAC should prefer OPAC description if one exists This patch modifies the patron entry form in the OPAC so that if street types are defined in authorized values, the OPAC description is preferred. To test, apply the patch and go to Administration -> Authorized values. - Add or edit entries in the "ROADTYPE" category. - Some entries should have only the "Description" set, while others should have "Description" and "Description (OPAC)". - In the OPAC, open the patron registration page. Check the "Stree type" drop down in the "Main address" section. - For entries which have an OPAC description, this value should show. - For entries without an OPAC description the default should show. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121863 [details] [review] Bug 27348: Fix test on ALTERNATE_INDEXER_DAEMON in koha-indexer Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 122214 [details] [review] Bug 28511: Road types in OPAC should prefer OPAC description if one exists This patch modifies the patron entry form in the OPAC so that if street types are defined in authorized values, the OPAC description is preferred. To test, apply the patch and go to Administration -> Authorized values. - Add or edit entries in the "ROADTYPE" category. - Some entries should have only the "Description" set, while others should have "Description" and "Description (OPAC)". - In the OPAC, open the patron registration page. Check the "Stree type" drop down in the "Main address" section. - For entries which have an OPAC description, this value should show. - For entries without an OPAC description the default should show. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
Depends on Bug 18112 not in 20.11.x