Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in staff-global.js.
Created attachment 121668 [details] [review] Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window.
Created attachment 121697 [details] [review] Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121857 [details] [review] Bug 28522: Correct eslint errors in staff-global.js This patch makes minor corrections to staff-global.js in order to quiet warnings from ESLint. This includes: - Remove unused variables - Declare undeclared variables - Update list of global and exported variables and functions - Correct whitespace - Remove an unused function (paramOfUrl) To test, apply the patch and clear your browser cache if necessary. - Confirm that the first search header form field has focus when switching bewteen pages. - Confirm that text entered in any search header form field persists when you switch search header form tabs, e.g. a word typed into the "Check out" tab is copied to the "Check in" form when you switch to that tab. - Perform a search from the "Search the catalog" tab in the header. On the search results page and any following detail page your search term should remain in the header search form. - From a bibliographic detail page, confirm that selecting a list from the "Add to list" button menu correctly triggers a popup window. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
Pushed to 20.11.x for 20.11.08
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.