19.11 warning like: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/opac/opac-MARCdetail.pl line 312. Same code, line 313 in master. Trivial fix.
Created attachment 121794 [details] [review] Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You need an item with some null values. Check your logs before and after applying this change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 121810 [details] [review] Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan.
Created attachment 121894 [details] [review] Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 122164 [details] [review] Bug 28545: Noisy uninitialized warn at opac-MARCdetail.pl line 313 Test plan: You do not even need a NULL value in a authorised value controlled item field, a zero in damaged or withdrawn is enough to trigger the warnings. (Because only the 1 is linked to an authvalue.) Check your plack-opac-error.log before and after applying this change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Without the patch I had at least four warnings per item: withdrawn, lost, damaged and notforloan. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
Note that behavior in staff interface in catalogue/MARCdetail.pl is different : $item->{ $subf[$i][0] } .= GetAuthorisedValueDesc( $field->tag(), $subf[$i][0], $subf[$i][1], '', $tagslib) || $subf[$i][1];
Pushed to 20.11.x for 20.11.08
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.