In itemsearch form, there are several filters build with authorized values or item types. There values should be sorted by description.
Created attachment 121820 [details] [review] Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface
Created attachment 121821 [details] [review] Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value
If needed I will create a unit test
Created attachment 121891 [details] [review] Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121892 [details] [review] Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121935 [details] [review] Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 121936 [details] [review] Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
One test is failing with those 2 patches applied: # Failed test at t/db_dependent/AuthorisedValues.t line 236. # Structures begin differing at: # $got->[0]{opac_description} = 'opac display value 0' # $expected->[0]{opac_description} = 'opac display value undef'
Created attachment 123451 [details] [review] Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t
Created attachment 123464 [details] [review] Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 123465 [details] [review] Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 123466 [details] [review] Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind <david@davidnind.com>
*** Bug 27565 has been marked as a duplicate of this bug. ***
Also tested for translated item type descriptions. Note: you need to have at least one additional language installed.
Created attachment 124209 [details] [review] Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 124210 [details] [review] Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 124211 [details] [review] Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.04
Pushed to 20.11.x for 20.11.10
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.