Bug 2856 - Duplicate patrons are not detected
Summary: Duplicate patrons are not detected
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Nahuel Angelinetti
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-10 07:09 UTC by Nahuel Angelinetti
Modified: 2012-10-25 23:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bugfix for HEAD (4.91 KB, patch)
2008-12-10 08:12 UTC, Chris Cormack
Details | Diff | Splinter Review
bugfix for 3.0.x (4.91 KB, patch)
2008-12-10 08:13 UTC, Chris Cormack
Details | Diff | Splinter Review
replace previous for 3.0.x (4.93 KB, text/x-patch)
2008-12-10 08:29 UTC, Chris Cormack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:57:14 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2008-12-10 07:09:07 ----

When you try to add a patron that already exists, the check is done, BUT it's not showed and the borrower is added.
Other problem, is the check is done with the birthdate but, it's not a required field, so if it's empty, but in the database the birthdate is set for the duplicate patron, it never found it. The date must be checked only if one is specified.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2008-12-10 08:12:03 ----

Created an attachment
bugfix for HEAD





---- Additional Comments From nahuel.angelinetti@biblibre.com 2008-12-10 08:13:51 ----

Created an attachment
bugfix for 3.0.x





---- Additional Comments From nahuel.angelinetti@biblibre.com 2008-12-10 08:29:24 ----

Created an attachment
replace previous for 3.0.x





---- Additional Comments From gmcharlt@gmail.com 2008-12-29 11:56:23 ----

Patch pushed to 3.1.  Please test and close.



---- Additional Comments From rch@liblime.com 2009-05-19 20:29:27 ----


The patch pushed to head inappropriately prevents two people with the same name from existing in the same Koha installation.  As pointed out in code comments around this bit of code, you can't require a test against fields that aren't necessarily required (e.g. firstname and dateofbirth).

There's some template code that appears to offer an override option (using tmpl var 'answernodouble'), but the script ignores this, and silently fails to add a new member.




---- Additional Comments From arm@hanover.ca 2009-05-21 19:22:50 ----

We have at least two cases where people in our town have the same name even to the same middle initial (in fact there are even 2 sets of my relatives with the same names, and we are not a large clan). 
Certainly Koha should alert us if we add a new patron with the same name, but it should allow duplicate names to be added - perhaps an "Are you sure? y/n" prompt for staff confirmation.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:57 UTC  ---

This bug was previously known as _bug_ 2856 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2856
Imported an attachment (id=892)
Imported an attachment (id=893)
Imported an attachment (id=894)

Actual time not defined. Setting to 0.0
CC member arm@hanover.ca does not have an account here
CC member nblake@masscat.org does not have an account here
CC member rch@liblime.com does not have an account here
The original submitter of attachment 892 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 893 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 894 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.