This syspref is missing.
Created attachment 121916 [details] [review] Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121919 [details] [review] Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Testing notes - was not sure of the best way to test this: - Checked that AllowHoldItemTypeSelection is a valid system preference - Checked the diff for the patch to make sure system preference name was correctly added If sharing statistics is enabled, then, like any other other system preference, its usage will be shared on Hea.
Created attachment 121930 [details] [review] Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121931 [details] [review] Bug 28267: (QA follow-up) Fix unit test Add the new preference to the UsageStats.t To test: - Run t/db_dependent/UsageStats.t - Watch it pass :)
Created attachment 121933 [details] [review] Bug 28563: Add AllowHoldItemTypeSelection to HEA This patch adds the mentioned syspref to the sysprefs list, shared for statistical purposes. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 121934 [details] [review] Bug 28267: (QA follow-up) Fix unit test Add the new preference to the UsageStats.t To test: - Run t/db_dependent/UsageStats.t - Watch it pass :) https://bugs.koha-community.org/show_bug.cgi?id=28563 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #7) > Created attachment 121934 [details] [review] [review] > Bug 28267: (QA follow-up) Fix unit test > > Add the new preference to the UsageStats.t > > To test: > - Run t/db_dependent/UsageStats.t > - Watch it pass :) > > https://bugs.koha-community.org/show_bug.cgi?id=28563 > > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thanks, Katrina. Good catch :-D
Pushed to master for 21.11, thanks to everybody involved!
Created attachment 122226 [details] [review] Bug 28563: (QA follow-up) Fix unit test Add the new preference to the UsageStats.t To test: - Run t/db_dependent/UsageStats.t - Watch it pass :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Fixed bug number on second patch.
(In reply to Jonathan Druart from comment #11) > Fixed bug number on second patch. Argh, thank you!
Enhancement not backported to 21.05.x