In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected.
Created attachment 122022 [details] [review] Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected
Please remember: - The title of the bug report describes shortly what the *problem is* - The title of the patch describes shortly what the *patch does* https://wiki.koha-community.org/wiki/Commit_messages
Created attachment 122032 [details] [review] Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected Signed-off-by: David Nind <david@davidnind.com>
(In reply to Jonathan Druart from comment #2) > Please remember: > - The title of the bug report describes shortly what the *problem is* > - The title of the patch describes shortly what the *patch does* > > https://wiki.koha-community.org/wiki/Commit_messages Arf indeed, i'll try to do better
Created attachment 122128 [details] [review] Bug 28569: In opac-suggestions.pl preselect user library In OPAC new purchase suggestion opac-suggestions.pl for library combobox : actually first value is selected, user library should be selected. Test plan : 1) Create a new library named 'ZZZ top' 2) Set this library on a user U1 2) Loggin at OPAC with user U1 3) Create a new suggestion => Check library 'ZZZ top' is preselected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(In reply to Fridolin Somers from comment #4) > (In reply to Jonathan Druart from comment #2) > > Please remember: > > - The title of the bug report describes shortly what the *problem is* > > - The title of the patch describes shortly what the *patch does* > > > > https://wiki.koha-community.org/wiki/Commit_messages > > Arf indeed, i'll try to do better Do it please.
Done,
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03
Pushed to 20.11.x for 20.11.09
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.