C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $self->borrowernumber, message_transport_type => 'email', } ) or warn "can't enqueue letter $letter";
Created attachment 122058 [details] [review] Bug 28582: Fix hashref in a warning message Can't enqueue letter HASH(0x55edf1806850) Test plan: If you cancel an article request when there is no email address (no branch email, no KohaAdminEmailAddress), Koha warns. Verify that the warning now contains the letter code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Self signoff: trivial++
Created attachment 122060 [details] [review] Bug 28582: Fix hashref in a warning message Can't enqueue letter HASH(0x55edf1806850) Test plan: If you cancel an article request when there is no email address (no branch email, no KohaAdminEmailAddress), Koha warns. Verify that the warning now contains the letter code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works perfectly :). Passing QA I feel like there's a pattern here begging to be adopted for the rest of the 'EnqueueLetter' calls.. but that can wait for another bug.
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
Pushed to 20.11.x for 20.11.08
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.