about.pl:#use Smart::Comments '####'; admin/preferences.pl:# use Smart::Comments; labels/spinelabel-home.pl:# use Smart::Comments; members/printslip.pl:#use Smart::Comments; members/update-child.pl:# use Smart::Comments; serials/subscription-add.pl:#use Smart::Comments; But there are no '###' in those files.
Created attachment 122357 [details] [review] Bug 28624: Remove Smart::Comments It's not used in those files (there is no occurrence of ###), and it's not installed anyway (it is by koha-testing-docker however). We should remove those lines. Test plan: Confirm the above
Patch no longer applies 8-(... Looks like members/printslip.pl is already fixed.
Created attachment 122602 [details] [review] Bug 28624: Remove Smart::Comments It's not used in those files (there is no occurrence of ###), and it's not installed anyway (it is by koha-testing-docker however). We should remove those lines. Test plan: Confirm the above
Created attachment 122742 [details] [review] Bug 28624: Remove Smart::Comments It's not used in those files (there is no occurrence of ###), and it's not installed anyway (it is by koha-testing-docker however). We should remove those lines. Test plan: Confirm the above Signed-off-by: David Nind <david@davidnind.com>
Created attachment 122868 [details] [review] Bug 28624: Remove Smart::Comments It's not used in those files (there is no occurrence of ###), and it's not installed anyway (it is by koha-testing-docker however). We should remove those lines. Test plan: Confirm the above Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported for 21.05