Currently, the ILSDI authentication route does not set the lastseen date for a borrower record. It should.
Created attachment 122421 [details] [review] Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending.
See also bug 15504, comment 28 and comment 29.
Created attachment 122422 [details] [review] Bug 28630: Add unit tests
In bug 28467 I just updated the working on TrackLastPatronActivity to accurately describe the current behavior. Please include an update there to tell people it now includes ILS-DI. The comment Magnus links off to also mentions API actions. I agree we should also cover that with lastseen. I don't see a separate bug for that. Martin, are you up for folding that in here?
Created attachment 122476 [details] [review] Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending.
Created attachment 122477 [details] [review] Bug 28630: Add unit tests
Created attachment 122478 [details] [review] Bug 28630: (follow-up) Update wording of syspref
(In reply to Andrew Fuerste-Henry from comment #4) > In bug 28467 I just updated the working on TrackLastPatronActivity to > accurately describe the current behavior. Please include an update there to > tell people it now includes ILS-DI. I've added a follow-up with the wording change, thanks for pointing it out :) > The comment Magnus links off to also mentions API actions. I agree we should > also cover that with lastseen. I don't see a separate bug for that. Martin, > are you up for folding that in here? Whilst I sort of agree with Magnus, there isn't really an 'IdentifyUser/AuthenticateUser' route in the API as yet and as such not a clear location to tie this too.. the REST API is still more closely tied to third part integrators acting on someone's behalf and doesn't really denote a user interaction which I feel lastseen is for. So yeah.. I'd wait until such a time that OAuth code grant or similar is introduced which would more clearly denote an actual user login.
Created attachment 122490 [details] [review] Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 122491 [details] [review] Bug 28630: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 122492 [details] [review] Bug 28630: (follow-up) Update wording of syspref Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Tested and signed off, but I should have thought sooner about how this was going to run into bug 28455, also signed off.
Created attachment 122544 [details] [review] Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122545 [details] [review] Bug 28630: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 122546 [details] [review] Bug 28630: (follow-up) Update wording of syspref Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
There is a conflict on the last patch, Martin can you have a look please? Should be easy for a native English speaker :)
Created attachment 123448 [details] [review] Bug 28630: Add track_login_daily to ILSDI::AuthenticatePatron This patch adds a call to track_login_daily for the AuthenticatePatron method in ILSDI. Many libraries use this ILSDI endpoint for electron book borrowing and need to maintain the lastseen based on this type of lending.
Created attachment 123449 [details] [review] Bug 28630: Add unit tests
Created attachment 123450 [details] [review] Bug 28630: (follow-up) Update wording of syspref
Created attachment 123454 [details] [review] Bug 28630: Improve date comparisons in tests
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03 by request.
Since Bug 28455 is in 20.11.x, I choose to backport this one also. I skipped "Update wording of syspref", I does not apply because text is different. I this it is not very important. Pushed to 20.11.x for 20.11.09
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.