When a user is logged into the OPAC and OPACHoldsHistory is enabled a list of holds and old holds is displayed. If a user selects one of these titles a "not found" error is displayed. opac-holdshistory.tt line 105: <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% hold.biblio.biblionumber | uri %]">[% INCLUDE 'biblio-title.inc' biblio=hold.biblio %]</a></td> This is an intranet URL so the OPAC user will not have access. opac-holdshistory should be: <td><a href="cgi-bin/koha/opac-detail.pl?biblionumber=[% hold.biblio.biblionumber | uri %]">[% INCLUDE 'biblio-title.inc' biblio=hold.biblio %]</a></td>
Created attachment 122510 [details] [review] Bug 28631: Holds History title link returns "not found" error This patch corrects a broken path in the OPAC holds history page. This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern. To test, apply the patch and log into the OPAC as a patron who has past or current holds. - View the "your holds history" page. - Click a title link in the table of holds. It should take you to the correct bibliographic detail page. - Check the breadcrumbs of the page. They should look consistent with breadcrumb navigation on other pages in the OPAC.
Created attachment 122755 [details] [review] Bug 28631: Holds History title link returns "not found" error This patch corrects a broken path in the OPAC holds history page. This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern. To test, apply the patch and log into the OPAC as a patron who has past or current holds. - View the "your holds history" page. - Click a title link in the table of holds. It should take you to the correct bibliographic detail page. - Check the breadcrumbs of the page. They should look consistent with breadcrumb navigation on other pages in the OPAC. Signed-off-by: Kelly <kelly@bywatersolutions.com>
Created attachment 122866 [details] [review] Bug 28631: Holds History title link returns "not found" error This patch corrects a broken path in the OPAC holds history page. This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern. To test, apply the patch and log into the OPAC as a patron who has past or current holds. - View the "your holds history" page. - Click a title link in the table of holds. It should take you to the correct bibliographic detail page. - Check the breadcrumbs of the page. They should look consistent with breadcrumb navigation on other pages in the OPAC. Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03
Pushed to 20.11.x for 20.11.09 > This patch also corrects the breadcrumb markup which didn't conform to the new Bootstrap 4 pattern. I did not include this change, only fixed the href.
Missing dependencies for 20.05.x, it shouldn't be affected, no backport.