Bug 28674 - old_reserves.item_level_hold and reserves.item_level_hold comments have typo "hpld" not "hold"
Summary: old_reserves.item_level_hold and reserves.item_level_hold comments have typo ...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2021-07-07 13:30 UTC by Henry Bolshaw
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Circulation function:

Attachments
Bug 28674: Fix typo 'hlpd' in schema comments (2.09 KB, patch)
2023-02-04 23:21 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 28674: Fix typo 'hlpd' in schema comments (2.14 KB, patch)
2023-02-06 13:36 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 28674: Fix typo 'hlpd' in schema comments (2.20 KB, patch)
2023-02-07 13:18 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Bolshaw 2021-07-07 13:30:55 UTC 
The reserves and old_reserves table schemas have typos in the comments for the item_level_hold field.

The comments say "Is the hpld placed at item level" but it should be "Is the hold placed at item level".

The typo is in the 21.05, 20.11, 20.05 and 19.11 versions.

http://schema.koha-community.org/21_05/tables/reserves.html

http://schema.koha-community.org/21_05/tables/old_reserves.html
Comment 1 Katrin Fischer 2023-02-04 23:21:54 UTC 
Created attachment 146176 [details] [review]
Bug 28674: Fix typo 'hlpd' in schema comments

Fixes the lines for old_reserves.item_level_hold and
reserves.item_level_hold comments to read 'hold'
instead of 'hpld'

To test:
* The easiest way to verify this change is by looking
at the patch itself
Comment 2 Owen Leonard 2023-02-06 13:36:15 UTC 
Created attachment 146268 [details] [review]
Bug 28674: Fix typo 'hlpd' in schema comments

Fixes the lines for old_reserves.item_level_hold and
reserves.item_level_hold comments to read 'hold'
instead of 'hpld'

To test:
* The easiest way to verify this change is by looking
at the patch itself

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2023-02-07 13:18:46 UTC 
Created attachment 146325 [details] [review]
Bug 28674: Fix typo 'hlpd' in schema comments

Fixes the lines for old_reserves.item_level_hold and
reserves.item_level_hold comments to read 'hold'
instead of 'hpld'

To test:
* The easiest way to verify this change is by looking
at the patch itself

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-02-07 13:50:13 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-02-08 16:37:28 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 6 Jacob O'Mara 2023-02-13 09:45:44 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.