In a previous bug, we standardized wording of several calendar-related sysprefs so they'd be easy to find in a single search. We should have included ExcludeHolidaysFromMaxPickupDelay in that.
Highlighting some of the issue around these, I filed this bug with the wrong syspref in the name. This is actually about ExpireReservesOnHolidays. Right now it reads: (Allow / Don't allow) expired holds to be canceled on days the library is closed.
Created attachment 122956 [details] [review] Bug 28677: Update wording on ExpireReservesOnHolidays To test: 1: look at ExpireReservesOnHolidays syspref description 2: apply patch, restart 3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar"
Created attachment 122960 [details] [review] Bug 28677: Update wording on ExpireReservesOnHolidays To test: 1: look at ExpireReservesOnHolidays syspref description 2: apply patch, restart 3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 123161 [details] [review] Bug 28677: Update wording on ExpireReservesOnHolidays To test: 1: look at ExpireReservesOnHolidays syspref description 2: apply patch, restart 3: look at wording again, see that it now clarifies that it only pertains to systems using ExpireReservesMaxPickUpDelay and includes the word "calendar" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 123162 [details] [review] Bug 28677: (QA follow-up) Correct capitalization Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Enhancement not backported to 21.05