Some librarians would find it handy if the circulation overdue report (overdue.tt) included a shelving location column. Since the table is already column configurable the new column would need to be added to columns_settings.yml as well
Created attachment 122684 [details] [review] Bug 28695: add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well
Created attachment 123685 [details] [review] Bug 28695: add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 123713 [details] [review] Bug 28695: add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Adding Barbara's sign-off line back to the patch as there was an overlap with sign-offs here - thx Kelly and Barbara!
Created attachment 124228 [details] [review] Bug 28695: Add shelving location column to overdue.tt To test: 1. have some overdues 2. go to the overdue report on the circulation page (overdue.tt) 3. no shelving location 4. apply patch and restart the things 5. look at the overdue report again and there should be a Shelving location column 6. make sure it is accurate 7. go to table settings and make sure you can properly hide the column. test other columns in the table and make sure they are still hiding correctly as well Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!