To recreate: - have a patron with edit_items permission but not edit_catalogue - log in as that patron - find a bib record with at least one item, click the to Items tab - Notice there is not am "Edit item" button under each barcode - Click back to the Normal tab, confirm you can successfully edit the item via the other Edit buttons - go back to your patron record, give yourself edit_catalogue permission - go back to your bib, to the items tab, confirm the edit link appears
Created attachment 122992 [details] [review] Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows
Created attachment 123209 [details] [review] Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 123726 [details] [review] Bug 28727: Show edit item link when user has edit items permission To test: 1: log in as a user with edit_items but not edit_catalogue 2: confirm you do not get an Edit Item link on moredetail.pl 3: apply patch, restart, reload 4: confirm link now shows Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 123727 [details] [review] Bug 28727: (QA follow-up) Simplify permission check There was another permission check for edit_items directly below, so instead of changing them to both be edit_items, I think we can now remove one. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03
Another funny behavior. With only edit_items you have access and links to "Cataloguing" home page, but its empty. It is for another bug report.
Pushed to 20.11.x for 20.11.09
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.