Created attachment 123114 [details] [review] Restore the database name to Koha dumps The line to use the --databases flag with mysqldump by default was accidentally removed from koha-dump when the --schema-only option was added. This makes all backups act as if koha-dump is called with the --without-db-name flag, causing koha-restore to fail to restore the database because it's neither CREATEd or USEd.
Caused by: commit d406d9016460ec8819d68d5d861627c5b3b5accb Bug 26947: Add schema-only option to koha-dump Is your patch ready for testing, Jason?
It is, I just missed changing the status to say so. Thanks for the reminder. :)
Created attachment 123254 [details] [review] Bug 28749: Restore the database name to Koha dumps The line to use the --databases flag with mysqldump by default was accidentally removed from koha-dump when the --schema-only option was added. This makes all backups act as if koha-dump is called with the --without-db-name flag, causing koha-restore to fail to restore the database because it's neither CREATEd or USEd. This patch restores that line To test: 1 - sudo debian/scripts/koha-dump kohadev 2 - zcat /var/spool/koha/kohadev/kohadev-2021-07-28.sql.gz | grep DATABASE 3 - Notice no output 4 - Apply patch 5 - sudo debian/scripts/koha-dump kohadev 6 - zcat /var/spool/koha/kohadev/kohadev-2021-07-28.sql.gz | grep DATABASE 7 - You get the line: CREATE DATABASE /*!32312 IF NOT EXISTS*/ `koha_kohadev` /*!40100 DEFAULT CHARACTER SET latin1 */; Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Trivial, passing QA Thanks Jason!
Pushed to master for 21.11, thanks to everybody involved!
Congratulations, Jason, for your first patch pushed! :)
Woo! Hopefully the next one will be a bit more substantial. :)
Pushed to 21.05.x for 21.05.03
Depends on Bug 26947 not in 20.11.x