Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch
Created attachment 123723 [details] [review] Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch
Created attachment 123724 [details] Screenshot with patch (modification)
Created attachment 123725 [details] Screenshot with patch (deletion)
Applying: Bug 28840: Better texts in batch record modification/deletion Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28840: Better texts in batch record modification/deletion hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28840-Better-texts-in-batch-record-modificatio-wjnSzH.patch Patch doesn't apply. But very easy to fix.
Created attachment 131538 [details] [review] Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch
Thanks a lot for testing Samu
Created attachment 131781 [details] [review] Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Looks good, works as expected. Thanks Fridolin.
I believe it should probably be IDs instead of ids? The internet suggests so, but maybe we could still have a native speaker weigh in? Example: <li><a href="#enterlist_tab">Enter a list of record ids</a></li>
Created attachment 133713 [details] [review] Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 133714 [details] [review] Bug 28840: (QA follow-up) Update id to ID Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #9) > I believe it should probably be IDs instead of ids? The internet suggests > so, but maybe we could still have a native speaker weigh in? > > Example: > <li><a href="#enterlist_tab">Enter a list of record ids</a></li> I didn't get a reply, so I have decided to provide a follow-up patch for consideration.
Created attachment 133729 [details] [review] Bug 28840: (QA follow-up) Update id to ID Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
(In reply to Katrin Fischer from comment #12) > I didn't get a reply, so I have decided to provide a follow-up patch for > consideration. I agree with your change!
(In reply to Owen Leonard from comment #14) > (In reply to Katrin Fischer from comment #12) > > I didn't get a reply, so I have decided to provide a follow-up patch for > > consideration. > > I agree with your change! Thx for the feedback!
Pushed to master for 22.05, thanks to everybody involved [U+1F984]