The page replicated the behavior from the holds history page on staff and added: [% IF show_itemtype_column %] <th>Requested item type</th> [% END %] but 'show_itemtype_column' is never set. To reproduce: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show
Created attachment 123842 [details] [review] Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 123862 [details] [review] Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 123869 [details] [review] Bug 28861: Item type column always hidden in OPAC holds history This patch fixes the 'Requested item type' column not showing for holds history in OPAC. It was due to a template variable not being set. When solved, it become clear that an import was missing for a template plugin. To test: 1. Enable AllowHoldItemTypeSelection 2. Add a couple item-type constrained holds 3. See them in the holds history page => SUCCESS: Item type column shows 4. Enable OPACHoldsHistory 5. Look for them in the OPAC => FAIL: The item type column doesn't show 6. Apply this patch 7. Repeat 5 => SUCCESS: The column shows! The item type is described! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03
Pushed to 20.11.x for 20.11.10
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.