Bug 2891 - Cannot manually enter dates in some report forms
Summary: Cannot manually enter dates in some report forms
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-01 11:17 UTC by Chris Cormack
Modified: 2012-10-25 23:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (6.01 KB, patch)
2011-08-22 16:27 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Fix for Bug 2891, cannot manually enter date at reports/issues_stats.pl (6.05 KB, patch)
2011-08-24 16:21 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:57:38 UTC


---- Reported by nicolas.morin@biblibre.com 2009-01-01 23:17:18 ----

On the reports/issues_stats.pl page, I cannot put the cursor in the dates boxes and actually type the date; I can only use the calendar to input a date. Once it's entered, I cannot manually edit the date : I can only select another date in it's place using the calendar.
To compare: things work just fine on reports/acquisitions_stats.pl
Tested with Firefox, Safari and Opera.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-01-05 07:35:32 ----

I think it's a normal comportment, to disallow the user to enter a date in his format and break the result page.



---- Additional Comments From nicolas.morin@biblibre.com 2009-01-07 05:48:02 ----

(In reply to comment #1)
> I think it's a normal comportment, to disallow the user to enter a date in his
> format and break the result page.
> 

It's a usability issue then : I, as a user, should not be made to think that I can enter a date; i.e. the textbox shouldn't be there, only the calendar?



---- Additional Comments From paul.poulain@biblibre.com 2009-01-07 05:50:06 ----

/me agrees with nicomo + averywhere in Koha, the date field & date selectors must/should be useable.
When the date selector was added, it was not the case sometimes, and some old code is still here.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:57 UTC  ---

This bug was previously known as _bug_ 2891 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2891

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was nicolas.morin@biblibre.com.

Comment 1 Owen Leonard 2011-08-22 16:27:48 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2011-08-24 16:21:51 UTC
Created attachment 5119 [details] [review]
[SIGNED-OFF] Fix for Bug 2891, cannot manually enter date at reports/issues_stats.pl

Removed unnecessary readonly attribute from date fields

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 3 Chris Cormack 2011-09-14 10:15:11 UTC
Pushed, please test
Comment 4 Chris Nighswonger 2011-10-26 18:02:32 UTC
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.